Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fastjet to conda-forge #133

Open
jmduarte opened this issue Nov 3, 2022 · 10 comments
Open

Add fastjet to conda-forge #133

jmduarte opened this issue Nov 3, 2022 · 10 comments
Assignees
Labels
enhancement New feature or request

Comments

@jmduarte
Copy link
Collaborator

jmduarte commented Nov 3, 2022

Inspired by #91.

It would be great to get fastjet on conda-forge (especially in time for the first real release 3.4.0.0, which now appears to be imminent). I'm unsure if we want to make this a requirement for the release. What do others think?

@lgray @jpivarski @chrispap95 @henryiii

@jmduarte jmduarte added the enhancement New feature or request label Nov 3, 2022
@lgray
Copy link
Collaborator

lgray commented Nov 3, 2022

In my experience first you make a pypi release then you stick it into conda forge which follows pypi.
You can see from conda-forge/staged-recipes#15961 a while ago that going in with an RC or something that's a little wonky can be quite some pain.

@jpivarski
Copy link
Member

Getting fastjet into conda-forge would be great!

As @lgray said, the conda-forge is a more frictionless process with non-RC releases. Only the first three digits of the version number (3.4.0) are constrained to match FastJet's; the fourth digit is free to increase as needed, so it is not necessary to get the conda-forge deployment right on the first non-RC attempt.

Also, the way that the conda-forge package gets populated is through the PyPI source wheel (e.g. fastjet-3.4.0.0.tar.gz). As long as the environment on conda-forge can take this tarball and compile all of its packages, it should work.

I'll also bring @chrisburr into this discussion, since he's a conda expert.

@jmduarte
Copy link
Collaborator Author

In progress by @lgray here: conda-forge/staged-recipes#21052

@jmduarte
Copy link
Collaborator Author

jmduarte commented Dec 16, 2022

@lgray @chrispap95 perhaps the blocker from before (conda-forge/staged-recipes#21052 (comment)) is now resolved by #159 ?

@eduardo-rodrigues
Copy link
Member

Adding a comment here so that I keep track of this for the inclusion of fastjet in the scikit-hep metapackage, see the discussions at scikit-hep/scikit-hep#173.

@eduardo-rodrigues
Copy link
Member

This is in fact done since a while, see https://github.com/conda-forge/fastjet-feedstock.

@lgray
Copy link
Collaborator

lgray commented May 4, 2024

Sorta - we got the recipe to work once for one version, and then the next version broke again. 🎉

@matthewfeickert
Copy link
Member

Yeah, this should maybe be left open as a reminder that we still need to get the latest versions building and also make them multiplatform (still only Linux at this point).

@eduardo-rodrigues
Copy link
Member

Indeed. Sorry for missing those facts.

@matthewfeickert
Copy link
Member

Nothing to be sorry about! This is a good reminder that we need to follow up on getting conda-forge setup properly across multiplatforms.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants