Fix for swig 4.1.X #159
Merged
Fix for swig 4.1.X #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Given one of these is some terminal banner for fastjet, check with the authors they don't want that appearing when you load the module or something. Even if it's not in the license it may be a good idea to check? Otherwise these look pretty benign, indeed. |
|
@lgray I admit I didn't check whether the banner still shows up or not. However, my guess is that it is unrelated to these static methods. I will check and I will reply back here. |
|
Just verified. Banner shows up as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swig 4.1.X changed the way it handles functions with
@staticmethod. Up to version 4.0.2 it used to produce an additional flat-named function for each static method. For example, the functionClusterSequence.fastjet_banner_stream()used to also have a flat-name counterpart:ClusterSequence_fastjet_banner_stream(). Now, this is gone.More info here swig/swig#2137
I just removed those imports. Tests seem to be fine and I couldn't find any uses for them.