ci: fix failing tests after update to upload-artifact v4 #273
Conversation
|
So it fixes the overwrite issue in the CI wheel tests. The real question is if it handles correctly the full wheel building process. Perhaps someone more knowledgeable should take a look at these changes. |
|
I personally don't use this action so I'm not sure if this will be correct. |
There was a problem hiding this comment.
Sorry, I don't have time to give a full useful review right this minute, but I can at least point you to scientific-python/cookie#350 which should show how to simplify things a bit.
Just make sure that both the upload and download are both on v4 or you'll have problems.
|
I implemented the changes as they are suggested in scientific-python/cookie#350 |
upload-artifact v4 cannot overwrite artifacts and this causes the tests to fail.