enabled cgal

[aryan26roy]

No description provided.

[aryan26roy]

@jpivarski , enabling cgal again breaks the wheel building on linux.

[chrispap95]

@lgray I was able to fix this in a local container. The problem here is that yum's boost-devel is the ancient version 1.53. However, fastjet relies on boost/predef.h that exists since 1.55. I had to download and unpack boost manually. Compilation & tests worked as expected. The reason why I didn't push a fix yet is that the boost mirrors are excruciatingly slow. I believe requesting the boost tarball from there would slow our wheels building a lot. I am not sure how to overcome this. Maybe find some alternative mirror for boost?

[lgray]

@chrispap95 that is completely non-obvious from the error message. Thank you for looking into this. I'll figure out something for a mirror.

[lgray]

So long as fastjet's usage of boost is really header only it seems that: https://github.com/boostorg/boost.git

is plenty fast. But I am guessing you tried that and found it lacking?

[chrispap95]

ahh actually no! I just used https://www.boost.org/users/download/
I didn't think to look on github! This might be sufficient!

[chrispap95]

@lgray did you manage to find any full releases on the boost github page? I only see tags that contain only the main repository (i.e. not recursive). I tried git clone --recusive but the size of the project is huge and it ends up being slower than the official mirrors. I just tried a curl from the official mirrors and it took ~4 mins. Not great not super bad. I will make a patch using that for the moment to make sure we have a working version and we can update it if we find a better alternative.

P.S. Is it legal to host the file ourselves?

[lgray]

Hmmm. moment.

[lgray]

Ah, I see I should have looked at the repository structure more closely. That's a bummer.

I think an additional four minutes to build wheels really isn't a big deal in the grand scheme of things, 11m vs 7m doesn't really change the course of one's day. I'd stick with your curl patch for now, so go ahead and toss it in.

We can probably host the file ourselves if we want to but that's some rather annoying additional burden to deal with.

[lgray]

eeeey it worked!

[chrispap95]

Thanks! Looks good now! And the download wasn't bad at all! (I am probably getting a terrible mirror where I am). I guess we are done?!