chore: remove invalid license expression #148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is invalid according to PEP 621 (which causes validate-pyproject to fail, from repo-review). There's no need for it anyway, as the Trove classifiers are sufficient.
Repo-review output:
General
hatchling.build
Projects must have documentation in a folder called docs (disable if not applicable)
GitHub Actions
At least one workflow should auto-cancel.
Pre-commit
Use
https://github.com/adamchainz/blacken-docs
instead ofhttps://github.com/asottile/blacken-docs
in.pre-commit-config.yaml
MyPy
Must have
show_error_codes = true
. This will print helpful error codes for users that clarify why something fails if you need to skip it.Must have
warn_unreachable = true
to pass this check. There are occasionally false positives (often due to platform or Python version static checks), so it's okay to ignore this check. But try it first - it can catch real bugs too.Must have
"ignore-without-code"
inenable_error_code = [...]
. This will force all skips in your project to include the error code, which makes them more readable, and avoids skipping something unintended.Must have
"redundant-expr"
inenable_error_code = [...]
. This helps catch useless lines of code, like checking the same condition twice.Must have
"truthy-bool"
inenable_error_code = []
. This catches mistakes in using a value as truthy if it cannot be falsey.Documentation
Should have a .readthedocs.yaml file in the root of the repository. Modern ReadTheDocs requires (or will require soon) this file.
Validate-PyProject
Checks
[build-system]
,[project]
,[tool.repo-review]
,[tool.setuptools]
Invalid pyproject.toml! Error:
project.license
must be valid exactly by one definition (2 matches found):