Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing dependency on packaging #1024

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: missing dependency on packaging #1024

merged 1 commit into from
Aug 21, 2024

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented Aug 15, 2024

This is used, but not declared. So many packages depend on this that it's being always pulled in for testing, but in a minimal environment it's missing.

See pyodide/pyodide#4767 (comment).

@HDembinski
Copy link
Member

Oh, I was under the impression that is a stdlib package. In that case, I should replace it, but for the time being, this is the right fix.

@HDembinski HDembinski merged commit 501b801 into develop Aug 21, 2024
9 checks passed
@HDembinski HDembinski deleted the henryiii-patch-1 branch August 21, 2024 07:31
@henryiii
Copy link
Member Author

I wouldn’t recommend replacing it, it is by far the standard tool for this. But it’s not distributed as part of the standard library because it needs to update at a higher frequency.

@HDembinski
Copy link
Member

I only use it to parse the version number. That can easily be replaced.

@henryiii
Copy link
Member Author

It is the canonical way to parse version numbers, and is a more reliable dependency than numpy, so IMO it's completely fine as a dependency. It's a dependency of pip even.

@henryiii
Copy link
Member Author

(Not saying you can't remove it if you really don't want it, just saying I think it's not a net positive to remove it. Same goes for other packages from the CPython core developers, like typing-extensions.)

@HDembinski
Copy link
Member

It is said in the README that iminuit's only hard dependency is on numpy. That is in its simplicity beautiful and I tend to keep it that way. You make good points, but this is a matter of style.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants