Minuit.interactive outside of Jupyter notebooks #1054
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adryyan Can I close this PR in favor of your other one, which I reviewed, or do you want to integrate the comments I made in the other PR in this PR? I only saw that you submitted similar work here after I read the other PR. |
|
@HDembinski Yes, let's close this one and I'll work on the other PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I kept the PyQt6 implementation as close to the ipywidgets one as I could. I only changed the layout of the Parameters a bit, which could easily be changed to follow the layout in ipywidgets, if desired. I also added a tab to view the results of the minimization. I haven't done any extensive testing or implemented any tests (or changed the existing ones) yet, but I tried the examples in the interactive fits tutorial. All examples should work except for the
CostSumbecause ofplt.sca(ax[i])(Issue #771 ).