Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding page on setting up GHA #56

Merged
merged 2 commits into from
May 20, 2020
Merged

Adding page on setting up GHA #56

merged 2 commits into from
May 20, 2020

Conversation

henryiii
Copy link
Member

@henryiii henryiii commented May 19, 2020

Basis for hepunits 1.2.0.

Had to revert to checkout/v1 due to issue with checkout/v2: actions/checkout#249 .

Copy link
Member

@eduardo-rodrigues eduardo-rodrigues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Only 2-3 trivial suggestions.

@henryiii henryiii merged commit cb6cd9a into master May 20, 2020
@henryiii henryiii deleted the henryiii/gha branch May 20, 2020 19:22
@matthewfeickert
Copy link
Member

It is possible to use actions/checkout@v2, as we did in pyhf PR 833 but there's obviously nothing wrong with staying on v1 for now.

@henryiii
Copy link
Member Author

You have to add the unshallow workaround. I assume that may kill any speed at vantage that v2 was supposed to give. Hoping it will be properly fixed, there's an issue for it. Setuptools_scm 4.0 will improve the situation (maybe just with a better error messege). They finally added submodules to v2 so there is hope!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants