Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set fsspec (s3fs) as default handler for s3 paths #1032

Merged
merged 7 commits into from
Nov 17, 2023
Merged

feat: set fsspec (s3fs) as default handler for s3 paths #1032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ec61012
feat: add fsspec as required dependency (#1021)
lobis Nov 14, 2023
91ef6cc
feat: set fsspec as default source (#1023)
lobis Nov 15, 2023
5d9bd31
set version to 5.2.0rc1 (release candidate)
lobis Nov 16, 2023
f86bd1a
set s3fs as default for s3
lobis Nov 16, 2023
c9f48b0
test different handlers
lobis Nov 16, 2023
738bec3
correct serialization of fsspec source
lobis Nov 16, 2023
243bcff
Merge branch 'main-fsspec' into s3fs-default-for-s3
lobis Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/uproot/_util.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,8 +435,8 @@ def file_path_to_source_class(file_path, options):
return source_cls, file_path

elif scheme == "s3":
# https://github.com/scikit-hep/uproot5/pull/1012
source_cls = uproot.source.s3.S3Source
# uproot.source.s3.S3Source
source_cls = uproot.source.fsspec.FSSpecSource
return source_cls, file_path

elif scheme in ("http", "https"):
Expand Down
2 changes: 1 addition & 1 deletion src/uproot/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

import re

__version__ = "5.1.2"
__version__ = "5.2.0rc1"
version = __version__
version_info = tuple(re.split(r"[-\.]", __version__))

Expand Down
Loading