Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: zstandard should be a test dependency, and xxhash goes with lz4. #1056

Merged
merged 1 commit into from
Dec 7, 2023
Merged

test: zstandard should be a test dependency, and xxhash goes with lz4. #1056

merged 1 commit into from
Dec 7, 2023

Conversation

jpivarski
Copy link
Member

No description provided.

@jpivarski jpivarski requested a review from ioanaif December 7, 2023 14:36
ioanaif
ioanaif approved these changes Dec 7, 2023
View reviewed changes
Copy link
Collaborator

@ioanaif ioanaif left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (discussed this over Zoom) Thank you for adding it!

@ioanaif ioanaif merged commit c5ff061 into main Dec 7, 2023
20 checks passed
@ioanaif ioanaif deleted the jpivarski/zstandard-should-be-a-test-dependency branch December 7, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ioanaif ioanaif ioanaif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jpivarski @ioanaif