Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Disable RNTuple tests for now and unpin selenium version #1334

Merged
merged 3 commits into from
Nov 13, 2024

Conversation

ariostas
Copy link
Collaborator

@ariostas ariostas commented Nov 7, 2024

Next week is the planned release of version 1.0 of the RNTuple spec. So soon I'll be starting to delete old RNTuple test files from scikit-hep-testdata and generate new ones with the v1.0 spec. This will break the CI tests, so I'm disabling the RNTuple tests so that it doesn't affect other PRs.

I'm also unpinning the selenium version that was pinned in #1327 since they released a fixed version.

@ariostas ariostas requested a review from jpivarski November 12, 2024 14:34
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good things to do (and, in my opinion, fine that they're both in the same PR; they're similar enough).

pyproject.toml Show resolved Hide resolved
@ariostas ariostas merged commit 56098c5 into main Nov 13, 2024
26 checks passed
@ariostas ariostas deleted the ariostas/disable_rntuple_tests branch November 13, 2024 19:14
pfackeldey pushed a commit to pfackeldey/uproot4 that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants