Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ReadOnlyDirectory attributes when fSeekKeys == 0 #660

Merged
merged 2 commits into from
Aug 4, 2022

Conversation

kakwok
Copy link
Contributor

@kakwok kakwok commented Aug 3, 2022

As titled. Fixes #658.

Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#660 and #661 fix the problem, and I'll merge them as soon as #661 passes tests (some technicality; I'm taking care of it as well as I can through the web interface). As soon as they go through, I'll start a new Uproot v4 release.

@jpivarski jpivarski merged commit ef1e695 into scikit-hep:main Aug 4, 2022
@jpivarski
Copy link
Member

@all-contributors please add @kakwok for code

@allcontributors
Copy link
Contributor

@jpivarski

I've put up a pull request to add @kakwok! 🎉

Moelf pushed a commit to Moelf/uproot5 that referenced this pull request Aug 18, 2022
* Set ReadOnlyDirectory attributes when fSeekKeys == 0

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

Co-authored-by: Martin <ka_hei_martin_kwok@brown.edu>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It's possible for a ReadOnlyDirectory to be created without all fields.
2 participants