fix: issues with members when dealing with non-numeric branches issue #906 #910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue was created when adding a way to deal with data having extra offsets.
For that, members were set to have a (None, None) item before headers were added (L234)
Then, in
objects.py
, themembers
var was cleared of the(None, None)
s. (L600)However, it was only tested in the case where a header is added after the Nones tuple, thus the while loop would stop at the first actual header and continue to clear the members var of Nones. In the file that caught this issue, no headers are appended and the
members
var in the end is equal only to (None, None) which causes this while loop to complain of index out of range.*** I used
range
to fix the issue, because of the way the condition is imposed. Ifenumerate
is used, pre-commit will complain of not usingfirst_value_loc
in the loop body.