Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: expressions failing in pandas issue 922 #930

Merged
merged 4 commits into from
Aug 10, 2023

Conversation

ioanaif
Copy link
Collaborator

@ioanaif ioanaif commented Aug 10, 2023

This PR fixes #922

The issue was caused by an assumption that in the code path that series are made of other series which are then to be transformed in dataframes.

@ioanaif ioanaif requested a review from jpivarski August 10, 2023 14:49
Copy link
Member

@jpivarski jpivarski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a better way of dealing with it than what I had in mind: modifying all of the functions (like where) so that Series inputs become Series outputs. This gets them all in one spot.

@jpivarski jpivarski enabled auto-merge (squash) August 10, 2023 14:52
@jpivarski jpivarski merged commit 26ee0f6 into main Aug 10, 2023
@jpivarski jpivarski deleted the ioanaif/fix-expressions-pandas-922 branch August 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"where" in expression fails with library "pandas"
2 participants