-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding a very basic FSSpecSource #967
Conversation
Great to see this starting! (We'll talk on Zoom in an hour.) I'm watching it, but I removed myself as a reviewer for now because you can use the "request review" button as a way of reminding me about it when it's done. I don't think I get emails about a PR going out of draft mode, but I do get emails about requests-to-review, so we use that as a last step in our process. |
@jpivarski @nsmith- I think this is ready to go. Currently the One of my next steps (for a dedicated PR) would be to refactor the I think this would introduce some limitations such as the ability to open some files with one protocol and some with another in the same function call, but as we discussed this is an acceptable compromise. The ability to use the previous sources ( The CI starting to fail when I added I saw that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! It adds a new class (which doesn't disturb any existing code yet) and it's following all of our local conventions. I think it's ready to merge.
future = uproot.source.futures.TrivialFuture(item) | ||
chunk = uproot.source.chunk.Chunk(self, start, stop, future) | ||
uproot.source.chunk.notifier(chunk, notifications)() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a blocking call in this first implementatation, but will be made asynchronous later.
…andlers-unify * origin/open-handlers-unify: feat: adding a very basic FSSpecSource (#967)
This PR simply adds the changes from #692 with the necessary updates to make it compatible with current uproot.
A very basic
Source
is implemented forfsspec
allowing the user to optionally usefsspec
by setting the appropiate handler in the read operation.