test: use file in skhep-testdata for issue #121 #973
Conversation
lobis
changed the title
There was a problem hiding this comment.
Is the github:// test using api.github.com with its rate limit? (This is continued from a conversation on Slack.)
If it is, let's just drop the github:// test. We can assume that fsspec does its job correctly (managing exotic backends like the GitHub one) and just verify that our connection to fsspec is doing what it's supposed to. We should continue testing local files, HTTP, XRootD, and maybe S3 because Uproot users are known to use them, but I'd say that the GitHub one is just "nice to have."
Other than that, I think this PR is ready to merge.
I think I will keep the pytest skip instead of just removing the test, I think it's nice to have an example of some of the exotic fsspec sources. I think there is some value in testing it explicitly though, for example the github schema url has two |
|
Okay. If we're ever working on something unrelated and see failures in this test, we'll unceremoniously drop it. You'll notice that some of the |
* single argument for handlers * style: pre-commit fixes * fix missing object source * add deprecation warnings for handler options * style: pre-commit fixes * use handler instead of *_handler * use file in skhep testdata * remove hyphen * use tag instead of branch (#973 (comment)) * remove network pytest mark (#973 (comment)) * use proper http links instead of local paths * use fsspec to split url * add comment * fix bad strip * working github test * add test for path split object * Update src/uproot/_util.py Co-authored-by: Jim Pivarski <jpivarski@users.noreply.github.com> * use urllib instead of fsspec for url parsing * move tests to dedicated file * do not shadow `object` * add more test cases * fsspec source as default * fix test * add xrootd handler default * correctly strip obj * revert merge * Revert "revert merge" This reverts commit 60300d6. * Revert "Revert "revert merge"" This reverts commit 2884e02. * update docstrings * update docstrings * direct the user to the handler option in docs * explain order of handler options --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jim Pivarski <jpivarski@users.noreply.github.com>
No description provided.