Forget legacy data dir #4662
Merged
Forget legacy data dir #4662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
emmanuelle
pushed a commit
that referenced
this pull request
May 8, 2020
* Forget legacy data dir * Add tests for data dir * Ignore pooch tests when github.com is not reachable
|
Nice touch up |
|
I think the problem is that some logic around making pooch optional got lost. I opened an issue for it. |
|
@meeseeksdev backport to v0.17.x |
|
Can't Dooooo.... It seem like this is already backported (commit is empty).I won't do anything. MrMeeseeks out. |
hmaarrfk
added a commit
to hmaarrfk/scikit-image
that referenced
this pull request
May 9, 2020
This reverts commit 137f144.
hmaarrfk
added a commit
to hmaarrfk/scikit-image
that referenced
this pull request
May 9, 2020
This reverts commit 137f144.
hmaarrfk
reviewed
May 9, 2020
| import numpy as np | ||
| import skimage.data as data | ||
| from skimage import io | ||
| from skimage._shared.testing import assert_equal, assert_almost_equal, fetch | ||
| from skimage._shared.testing import ( | ||
| assert_equal, assert_almost_equal, fetch, skipif |
There was a problem hiding this comment.
using fetch from here will automatically skip things if it is offline.
There was a problem hiding this comment.
or i guess, if pooch isn't installed. We can add an offline check too.
emmanuelle
added a commit
that referenced
this pull request
May 11, 2020
* Revert "Forget legacy data dir (#4662)" This reverts commit 137f144. * Make pooch an optional requirement * Make pooch an optional dependency * Add Pooch to documentation requirements * Fixup add documentation to the docstring * Add cell.png to the legacy registry * Update datadir order * Try to avoid circular stuff * Split up the init pooch function * Refine error message when pooch not found * Remove unused imports * Add the os directory test again * Add a test for download all * Add an error for installing Pooch. * Crosslink to our installation instructions * Update skimage/data/__init__.py Co-authored-by: Emmanuelle Gouillart <emma@plot.ly> Co-authored-by: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu> Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>
emmanuelle
added a commit
that referenced
this pull request
May 12, 2020
* Revert "Forget legacy data dir (#4662)" This reverts commit 137f144. * Make pooch an optional requirement * Make pooch an optional dependency * Add Pooch to documentation requirements * Fixup add documentation to the docstring * Add cell.png to the legacy registry * Update datadir order * Try to avoid circular stuff * Split up the init pooch function * Refine error message when pooch not found * Remove unused imports * Add the os directory test again * Add a test for download all * Add an error for installing Pooch. * Crosslink to our installation instructions * Update skimage/data/__init__.py Co-authored-by: Emmanuelle Gouillart <emma@plot.ly> Co-authored-by: Juan Nunez-Iglesias <juan.nunez-iglesias@monash.edu> Co-authored-by: Emmanuelle Gouillart <emma@plot.ly>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #4659
... I think. =P
Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.