Silence a few RuntimeWarnings in the test suite #4838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Internally, denoise wavelet considers regions where the detail coefficients are exactly zero to be masked. This leads to a warning about an empty slice that is irrelevant to this test case. Suppress this warning by just using a non-constant input array instead.
jni
approved these changes
Jul 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The first commit avoids a RuntimeWarning from NumPy related to taking
log(0)in pathological test cases ofthreshold_li.The second fix is in a
denoise_wavelettest case. Here, I modified the array used in the test to be non-constant to avoid the detail coefficient array being all zeros (internally to denoise_wavelet, values where the details are exactly 0 are assumed to be masked out, which was leading to an empty slice). The actual values in the array are irrelevant to that test case, so any non-constant array would work, I just chosearangearbitrarily.Checklist
./doc/examples(new features only)./benchmarks, if your changes aren't covered by anexisting benchmark
For reviewers
later.
__init__.py.doc/release/release_dev.rst.