Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alpha argument to adapted_rand_error #6472

Merged
merged 5 commits into from
Aug 31, 2022
Merged

Add alpha argument to adapted_rand_error #6472

merged 5 commits into from
Aug 31, 2022

Conversation

lucas-johnson
Copy link
Contributor

Resolves #6433

@pep8speaks
Copy link

pep8speaks commented Aug 18, 2022 •
edited
Loading

Hello @lucas-johnson! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2022-08-30 10:01:46 UTC

alexdesiqueira
alexdesiqueira suggested changes Aug 19, 2022
View reviewed changes
Copy link
Member

@alexdesiqueira alexdesiqueira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lucas-johnson!
I'll ask a few changes on the documentation, but otherwise this one looks good to me.

skimage/metrics/_adapted_rand_error.py Outdated Show resolved Hide resolved
skimage/metrics/_adapted_rand_error.py Outdated Show resolved Hide resolved
skimage/metrics/_adapted_rand_error.py Outdated Show resolved Hide resolved
@alexdesiqueira alexdesiqueira changed the title adapted rand error with alpha Add alpha argument to adapted_rand_error Aug 19, 2022
@alexdesiqueira alexdesiqueira added the ⏩ type: Enhancement Improve existing features label Aug 19, 2022
@lucas-johnson
Copy link
Contributor Author

Documentation tweaks made!

@lucas-johnson
Copy link
Contributor Author

As near as I can tell that test failure looks unrelated to this PR... local pytests are passing, with the exception of benchmark tests.

@lagru lagru mentioned this pull request Aug 21, 2022
Closed
@alexdesiqueira
Copy link
Member

Thank you @lucas-johnson! Looks good, thanks for this!

@alexdesiqueira
Copy link
Member

On the CI tests, I opened an issue: #6479.

@alexdesiqueira
Copy link
Member

@scikit-image/core please check and merge (if OK) / discuss (if not) this one. Thanks y'all!

rfezzani
rfezzani approved these changes Aug 30, 2022
View reviewed changes
Copy link
Member

@rfezzani rfezzani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lucas-johnson for your contribution, I just found a minor formatting issue 😉

skimage/metrics/_adapted_rand_error.py Outdated Show resolved Hide resolved
@jni @rfezzani
Fix docstring indentation in skimage/metrics/_adapted_rand_error.py
9fa741b 
Co-authored-by: Riadh Fezzani <rfezzani@gmail.com>
@rfezzani rfezzani merged commit f0a3fd1 into scikit-image:main Aug 31, 2022
@rfezzani
Copy link
Member

Pushing the green button 🎉 🙂 Thank you @lucas-johnson

@jarrodmillman jarrodmillman added this to the 0.20 milestone Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jni jni jni approved these changes

@rfezzani rfezzani rfezzani approved these changes

@alexdesiqueira alexdesiqueira alexdesiqueira approved these changes

Assignees
No one assigned
Labels
⏩ type: Enhancement Improve existing features
Projects
None yet
Milestone
0.20
Development

Successfully merging this pull request may close these issues.

Add alpha parameter to adapted_rand_error()
6 participants
@lucas-johnson @pep8speaks @alexdesiqueira @rfezzani @jni @jarrodmillman