-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
415 documentation for winkler interval score #444
415 documentation for winkler interval score #444
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this detailed page explaining MAPIE metrics is awesome. Thank you so much for listing everything here.
I've commented on the style and a question about the equations being too similar.
README.rst
Outdated
:height: 45px | ||
:width: 45px |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Incorrect image scale (distorted).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your changes. I just need to add a few harmonised changes. At the same time, I can't see your changes in the documentation (bug because there are a lot of builds / a lot of commits). I suggest you make a single commit for all the suggested changes with the "Add suggestion to batch" option in GitHub.
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add line breaks, and it will be perfect.
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simply add a line break to the format and you're done.
examples/regression/4-tutorials/plot_main-tutorial-regression.py
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 39 41 +2
Lines 4616 4803 +187
Branches 487 363 -124
==========================================
+ Hits 4616 4803 +187 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
Description
Add description for all the metrics.
Fixes #415
Please remove options that are irrelevant.
Checklist
make lint
make type-check
make tests
make coverage
make doc