-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Building of Ensemble Classifier from MapieClassifier #445
Building of Ensemble Classifier from MapieClassifier #445
Conversation
…larger dataset (raps limitation)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @thibaultcordier,
Great PR, thank you! Really clarifies the structure of MapieClassifier
as it should have been.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @thibaultcordier,
Just a last small change, be careful when changing tests, we don't want to reduce the generality of the tests performed!
Description
Fixes #430
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Adapt existing unit tests to the new class and check that everything still works.
Checklist
make lint
make type-check
make tests
make coverage
make doc