Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building of Ensemble Classifier from MapieClassifier #445

Merged
merged 42 commits into from
Jul 1, 2024

Conversation

BaptisteCalot
Copy link
Collaborator

@BaptisteCalot BaptisteCalot commented May 15, 2024

Description

  • Migration of some code from classification.py into estimator_classifier.py
  • Adapt unit tests

Fixes #430

Type of change

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Adapt existing unit tests to the new class and check that everything still works.

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

Copy link
Collaborator

@LacombeLouis LacombeLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thibaultcordier,
Great PR, thank you! Really clarifies the structure of MapieClassifier as it should have been.
Thank you!

mapie/estimator/regressor.py Show resolved Hide resolved
mapie/classification.py Outdated Show resolved Hide resolved
mapie/tests/test_classification.py Outdated Show resolved Hide resolved
mapie/tests/test_classification.py Show resolved Hide resolved
mapie/conformity_scores/checks.py Outdated Show resolved Hide resolved
@thibaultcordier thibaultcordier self-assigned this Jun 28, 2024
Copy link
Collaborator

@LacombeLouis LacombeLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @thibaultcordier,
Just a last small change, be careful when changing tests, we don't want to reduce the generality of the tests performed!

mapie/tests/test_classification.py Show resolved Hide resolved
@thibaultcordier thibaultcordier merged commit 044ae69 into scikit-learn-contrib:master Jul 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH : Build an Ensemble classifier based on regression refactoring
4 participants