Add : **predict_params in fit and predict method for Mapie Regression

[BaptisteCalot]

Description

Adding **predict_params for the predict methods of the models.

Fixes #492

Type of change

Please remove options that are irrelevant

• New feature (non-breaking change which adds functionality)
• This change requires a documentation update

In progress

• : Check that predict_params are correctly taken into account in the fit and predict methods
• : Check that fit_params and predict_params are correctly taken into account in the fit and predict methods
• : Check that an error is raise when predict_params are given to the predict method but not to the fit method

Checklist

• I have read the contributing guidelines
• I have updated the HISTORY.rst and AUTHORS.rst files
• Linting passes successfully : make lint
• Typing passes successfully : make type-check
• Unit tests pass successfully : make tests
• Coverage is 100% : make coverage
• Documentation builds successfully : make doc

[thibaultcordier]

Thank you @BaptisteCalot for your contribution to adding predict_params. Just a few suggestions:

• check that your changes in the interface class are compatible with the regression and classification subclasses
• check that your style code is as clear and clean as possible (too many empty lines which make it difficult to read your code)
• use the same convention everywhere (if you don't use a comma at the end of the method signature, do it everywhere)

I question your proposal to add predict-param in initialization. For me, it is not natural or usual to do so.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (614293e) to head (a495462).
Report is 548 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##            master      #471    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           39        44     +5     
  Lines         4616      5255   +639     
  Branches       487       890   +403     
==========================================
+ Hits          4616      5255   +639     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[thibaultcordier]

Consider previous comments in any part of your changes. The list is non-exhaustive:

• mapie/tests/test_regression.py, line 963: clean the test code by removing the unnecessary empty line
• mapie/tests/test_regression.py, line 1023: clean the test code by removing the unnecessary empty line
• mapie/tests/test_regression.py, line 44: use super init to reduce your code

[LacombeLouis]

Note that for the description of the **predict_params make sure to explain that these are the parameters for the estimator!

[LacombeLouis]

Good! One last change and we're there!

[thibaultcordier]

Thank you for your changes. Just one last one to add docstring into a function.

[LacombeLouis]

We're not testing that invalid predict params give an error. We're checking that if given in predict, we are also given one in fit, no?

[BaptisteCalot]

Done

[LacombeLouis]

I don't see the solution on this issue. We are checking that if no predict_params have been given in the fit, it's an issue.

[LacombeLouis]

I don't see the solution on this issue. We are checking that if no predict_params have been given in the fit, it's an issue.

[LacombeLouis]

Hey @BaptisteCalot, just some small updates. Note that you should make a last check for the linting, as the changes I've made don't verify linting!

On vacation.