-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ts-changepoint-notebook #487
Update ts-changepoint-notebook #487
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @BaptisteCalot, thank you for fixing the issue with this PR!
In this notebook we need to fix only the lower_quantiles
and higher_quantiles
. Additionally, we add the plot of this for the ACI
method.
Could you make a couple changes to improve the notebook:
- Make a function to calculate the
lower_quantiles
andhigher_quantiles
Note that this test has not been needed:
|
Description
Resolution of several issues within the Notebook ts-changepoint :
Reconstruction of the higher and lower quantiles, which were available as attributes of the MapieTimeSeriesRegressor() class in Mapie version 0.7 and were lost in version 0.8.
Addition of prediction interval calculations with adapt_conformal_inference for the aci method, modeled after what was developed in the notebook for the enbpi method
Fixes #475
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist
make lint
make type-check
make tests
make coverage
make doc