Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ts-changepoint-notebook #487

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

BaptisteCalot
Copy link
Collaborator

@BaptisteCalot BaptisteCalot commented Jul 19, 2024

Description

Resolution of several issues within the Notebook ts-changepoint :

  • Reconstruction of the higher and lower quantiles, which were available as attributes of the MapieTimeSeriesRegressor() class in Mapie version 0.7 and were lost in version 0.8.

  • Addition of prediction interval calculations with adapt_conformal_inference for the aci method, modeled after what was developed in the notebook for the enbpi method

Fixes #475

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Add test_inf_values_with_warning_inf() in order to test check_array_inf with warning_inf=True

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

@BaptisteCalot BaptisteCalot linked an issue Jul 19, 2024 that may be closed by this pull request
@BaptisteCalot BaptisteCalot marked this pull request as draft July 19, 2024 15:12
@BaptisteCalot BaptisteCalot marked this pull request as ready for review July 19, 2024 15:38
Copy link
Collaborator

@LacombeLouis LacombeLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BaptisteCalot, thank you for fixing the issue with this PR!
In this notebook we need to fix only the lower_quantiles and higher_quantiles. Additionally, we add the plot of this for the ACI method.

Could you make a couple changes to improve the notebook:

  • Make a function to calculate the lower_quantiles and higher_quantiles

@LacombeLouis
Copy link
Collaborator

Note that this test has not been needed:

@LacombeLouis LacombeLouis merged commit a9eb89a into master Jul 26, 2024
8 checks passed
@BaptisteCalot BaptisteCalot deleted the 475-issue-in-flow-of-ts-changepoint-notebook branch July 26, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue in flow of ts-changepoint notebook
2 participants