Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the existing tutorial on ts changepoint to align the notebook #490

Conversation

BaptisteCalot
Copy link
Collaborator

Description

There is a tutorial on time series that we will consider as a reliable source to improve the second part of our notebook with the changepoint

Here is the tutorial : https://mapie.readthedocs.io/en/latest/examples_regression/4-tutorials/plot_ts-tutorial.html

Fixes #489

Type of change

Please remove options that are irrelevant.

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • No unit tests

Checklist

  • I have read the contributing guidelines
  • I have updated the HISTORY.rst and AUTHORS.rst files
  • Linting passes successfully : make lint
  • Typing passes successfully : make type-check
  • Unit tests pass successfully : make tests
  • Coverage is 100% : make coverage
  • Documentation builds successfully : make doc

Copy link
Collaborator

@LacombeLouis LacombeLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @BaptisteCalot,
Thank you for this PR! Note that there is no need to keep all the rolling coverage [24 hours] plots (they are the same). Also, could you fix the random_state to make sure that the plots don't change too often.

Copy link
Collaborator

@LacombeLouis LacombeLouis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @BaptisteCalot, could you please make a mention of the clipping. Make sure to include it into the comments of the notebooks!

@BaptisteCalot BaptisteCalot merged commit 2823152 into master Aug 2, 2024
8 checks passed
@BaptisteCalot BaptisteCalot deleted the 489-use-the-existing-tutorial-on-ts-changepoint-to-align-the-notebook branch August 2, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the existing tutorial on ts-changepoint to align the notebook
2 participants