493 add mondrian cp #504
Merged
493 add mondrian cp #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
…/MAPIE into 493-add-mondrian-cp
Co-authored-by: Thibault Cordier <124613154+thibaultcordier@users.noreply.github.com>
thibaultcordier
requested changes
Aug 20, 2024
| plt.hlines(0.9, -1, 21, label="90% coverage", color="black", linestyle="--") | ||
| plt.ylabel("Coverage") | ||
| plt.legend(loc='upper left', bbox_to_anchor=(1, 1)) | ||
| plt.show() |
There was a problem hiding this comment.
You might need to fix fig size before (text is cut off at the moment).
thibaultcordier
approved these changes
Sep 3, 2024
Comment on lines
37
to
40
| ############################################################################## | ||
| # 1. Create the noisy dataset with 10 groups, each of those groups having | ||
| # a different level of noise. | ||
| # ------------------------------------------------------------------- |
There was a problem hiding this comment.
Not urgent, but if you have the time, the titles are not displayed properly -> you will have to see what's wrong or if it's intentional
LacombeLouis
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Include Mondrian CP in the MAPIE package as a wrapper of existing mapie estimators.
Fixes #(issue)
Type of change
Please remove options that are irrelevant.
New class
How Has This Been Tested?
I have tested that method worked with eligible mapie estimator and conformity scores and that it returned an error when either the estimator or the conformity score were not eligible.
Checklist
make lintmake type-checkmake testsmake coveragemake doc