Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pytest.approx insetad of np.array_allclose for a single float #380

Closed
wants to merge 1 commit into from

Conversation

massich
Copy link
Contributor

@massich massich commented Dec 1, 2017

Reference Issue

#323

What does this implement/fix? Explain your changes.

This is just an Idea of how the test would be. I would also use fixture to create a matrix of parameters and expected values. (instead of using this for loop)

Any other comments?

@codecov
Copy link

codecov bot commented Dec 1, 2017

Codecov Report

Merging #380 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   98.71%   98.72%   +0.01%     
==========================================
  Files          68       67       -1     
  Lines        3967     3929      -38     
==========================================
- Hits         3916     3879      -37     
+ Misses         51       50       -1
Impacted Files Coverage Δ
...er_sampling/prototype_generation/tests/__init__.py
imblearn/under_sampling/base.py 100% <0%> (+2.43%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14bda7c...946a2f5. Read the comment docs.

@glemaitre
Copy link
Member

Missing:

  • datasets/tests/test_zenodo.py
  • metrics/tests/test_classification.py

@glemaitre
Copy link
Member

This is just an Idea of how the test would be. I would also use fixture to create a matrix of parameters and expected values. (instead of using this for loop)

Yep but we need things to move quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants