Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH duck-typing scikit-learn estimator instead of inheritance #858

Merged
merged 53 commits into from
Jan 16, 2022
Merged

ENH duck-typing scikit-learn estimator instead of inheritance #858

merged 53 commits into from
Jan 16, 2022

Commits on Sep 2, 2021

  1. add duck-type check for KNeighbors-likeness

    sft-managed authored and sft-managed committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    d17b6b5 View commit details
    Browse the repository at this point in the history

  2. removal ofKNeighborsMixin type check

    sft-managed authored and sft-managed committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    379ea7e View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2021

  1. Added _is_neighbors_object() private validation function

    sft-managed authored and sft-managed committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    8790628 View commit details
    Browse the repository at this point in the history

  2. Addded pep8lank lines

    sft-managed authored and sft-managed committed Sep 9, 2021
    Configuration menu
    Copy the full SHA
    e997e23 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. change isinstance check for SVM estimator to simply clone the estimat… 

    …or - similar to _validate_estimator() in KMeansSMOTE
    sft-managed authored and sft-managed committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    94b0725 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2021

  1. remove explicit class-check for KMeans estimator

    sft-managed authored and sft-managed committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    9fbf360 View commit details
    Browse the repository at this point in the history

  2. remove explicit class check for KNeighborsClassifier

    sft-managed authored and sft-managed committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    f736879 View commit details
    Browse the repository at this point in the history

  3. remove explicit class check for KNeighborsClassifier in CondensedNear… 

    …estNeighbour
    sft-managed authored and sft-managed committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    fcb118e View commit details
    Browse the repository at this point in the history

  4. remove explicit class check for ClassifierMixin in InstanceHardnessTh… 

    …reshold
    sft-managed authored and sft-managed committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    a4e959c View commit details
    Browse the repository at this point in the history

  5. PEP 8 issue fix

    sft-managed authored and sft-managed committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    65ae4fd View commit details
    Browse the repository at this point in the history

  6. PEP 8 issue fix - line break before operator

    sft-managed authored and sft-managed committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    5b76d49 View commit details
    Browse the repository at this point in the history

  7. PEP 8 issue fix - no more line break before operator

    sft-managed authored and sft-managed committed Sep 13, 2021
    Configuration menu
    Copy the full SHA
    8284b70 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Undo changes to _instance_hardness_threshold

    sft-managed authored and sft-managed committed Sep 15, 2021
    Configuration menu
    Copy the full SHA
    e97ae36 View commit details
    Browse the repository at this point in the history

Commits on Sep 16, 2021

  1. revert OneSidedSelection changes

    sft-managed authored and sft-managed committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    495ec27 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2021

  1. Undo changes to CondensedNearestNeighbour

    sft-managed authored and sft-managed committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    10456f5 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2021

  1. example NearestNeighbors test

    sft-managed authored and sft-managed committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    93200e1 View commit details
    Browse the repository at this point in the history

  2. Use sklearn.base.clone to validate NN object and throw error

    sft-managed authored and sft-managed committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    f104057 View commit details
    Browse the repository at this point in the history

  3. undo last commit, and raise nn_object TypeError

    sft-managed authored and sft-managed committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    b82e4d9 View commit details
    Browse the repository at this point in the history

  4. remove unused imports

    sft-managed authored and sft-managed committed Sep 29, 2021
    Configuration menu
    Copy the full SHA
    70b6778 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Add test for cuml ADASYN

    sft-managed authored and sft-managed committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    c67c775 View commit details
    Browse the repository at this point in the history

  2. Updated check_neighbors_object docstring and error type

    sft-managed authored and sft-managed committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    010f4d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2021

  1. Updated tests

    sft-managed authored and sft-managed committed Oct 5, 2021
    Configuration menu
    Copy the full SHA
    178d0f0 View commit details
    Browse the repository at this point in the history

Commits on Oct 29, 2021

  1. Merge branch 'master' into ducktype-check_neighbors

    @NV-jpt
    NV-jpt authored Oct 29, 2021
    Configuration menu
    Copy the full SHA
    9868d0f View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2021

  1. Merge remote-tracking branch 'origin/master' into pr/NV-jpt/858

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    2e1ee17 View commit details
    Browse the repository at this point in the history

  2. duck-typing svm

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    8889cfd View commit details
    Browse the repository at this point in the history

  3. TST add couple of tests

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    5e875a0 View commit details
    Browse the repository at this point in the history

  4. better error message with duck-typing

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    9545172 View commit details
    Browse the repository at this point in the history

  5. iter

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    29a414b View commit details
    Browse the repository at this point in the history

  6. CI let's try a run on CircleCI with cuML

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    12991ba View commit details
    Browse the repository at this point in the history

  7. iter

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    e24ee06 View commit details
    Browse the repository at this point in the history

  8. iter

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    525002f View commit details
    Browse the repository at this point in the history

  9. iter

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    189f0e9 View commit details
    Browse the repository at this point in the history

  10. iter

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    2cbe273 View commit details
    Browse the repository at this point in the history

  11. iter

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    cc7fae9 View commit details
    Browse the repository at this point in the history

  12. ITER

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    29e4619 View commit details
    Browse the repository at this point in the history

  13. iter

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    a098e84 View commit details
    Browse the repository at this point in the history

  14. iter

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    0aa328e View commit details
    Browse the repository at this point in the history

  15. dbg

    @glemaitre
    glemaitre committed Dec 7, 2021
    Configuration menu
    Copy the full SHA
    8cce474 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2021

  1. dbg

    @glemaitre
    glemaitre committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    8d4ff31 View commit details
    Browse the repository at this point in the history

  2. MNT move to circleci

    @glemaitre
    glemaitre committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    0ceacfb View commit details
    Browse the repository at this point in the history

  3. iter

    @glemaitre
    glemaitre committed Dec 8, 2021
    Configuration menu
    Copy the full SHA
    ee6b7b0 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2022

  1. iter

    @glemaitre
    glemaitre committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    d089b7b View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into pr/NV-jpt/858

    @glemaitre
    glemaitre committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    ac7e00a View commit details
    Browse the repository at this point in the history

  3. create custom NN class

    @glemaitre
    glemaitre committed Jan 15, 2022
    Configuration menu
    Copy the full SHA
    d815e2d View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2022

  1. add test no dependent on cupy

    @glemaitre
    glemaitre committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    964d082 View commit details
    Browse the repository at this point in the history

  2. update documentation

    @glemaitre
    glemaitre committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    99d5206 View commit details
    Browse the repository at this point in the history

  3. iter

    @glemaitre
    glemaitre committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    48d1fd5 View commit details
    Browse the repository at this point in the history

  4. iter

    @glemaitre
    glemaitre committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    18b6057 View commit details
    Browse the repository at this point in the history

  5. revert redirector

    @glemaitre
    glemaitre committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    76fbd59 View commit details
    Browse the repository at this point in the history

  6. add changelog

    @glemaitre
    glemaitre committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    8fa97ed View commit details
    Browse the repository at this point in the history

  7. remove duplicated test

    @glemaitre
    glemaitre committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    615a2bf View commit details
    Browse the repository at this point in the history

  8. make testing function private

    @glemaitre
    glemaitre committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    b75b77d View commit details
    Browse the repository at this point in the history

  9. iter

    @glemaitre
    glemaitre committed Jan 16, 2022
    Configuration menu
    Copy the full SHA
    b627cf1 View commit details
    Browse the repository at this point in the history