Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PCovR-WHODataset takes super long to compute #175

Closed
PicoCentauri opened this issue Mar 27, 2023 · 3 comments
Closed

PCovR-WHODataset takes super long to compute #175

PicoCentauri opened this issue Mar 27, 2023 · 3 comments

Comments

@PicoCentauri
Copy link
Collaborator

The example suit of scikit-matter is super nice and well structured. Most of them run also fast, but while I was working on #170 on found that the PCovR-WHODataset examples take ages to compute.

It might be worth revising the example to speed this up. An example that takes several minutes for execution is not very useful. If there is no way to speed this up we at least should add a note.
@agoscinski
Copy link
Collaborator

agoscinski commented Mar 29, 2023 •
edited
Loading

I agree with that. That was also what I planned to do after the publication.

@rosecers
Copy link
Collaborator

I'll double-check the kernel CV bottleneck and see if we can significantly cut down there.

@rosecers rosecers mentioned this issue Apr 24, 2023
Merged
@rosecers
Copy link
Collaborator

Addressed in #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@agoscinski @PicoCentauri @rosecers