Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing kernel optimization from who example #189

Merged
merged 3 commits into from
Apr 24, 2023
Merged

Removing kernel optimization from who example #189

merged 3 commits into from
Apr 24, 2023

Conversation

rosecers
Copy link
Collaborator

@rosecers rosecers commented Apr 24, 2023

As I thought in #175, kernel optimization is a serious bottlebeck. @PicoCentauri can you see if this speeds things up significantly?


📚 Documentation preview 📚: https://scikit-matter--189.org.readthedocs.build/en/189/

Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, very nice and much faster. I added a switch with recalc=False that users can easily set to True to rerun the search locally.

@rosecers rosecers merged commit 44ea67d into main Apr 24, 2023
@rosecers rosecers deleted the speedup-who branch April 24, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants