Updating csd-1000r to contain a sufficient number of sample, use the … #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosecers
force-pushed
the
fix_csd1000r
branch
12 times, most recently
from
ab279b0 to
70cc69e
Compare
|
This branch conflicts with the main branch, can you rebase it? |
rosecers
force-pushed
the
fix_csd1000r
branch
3 times, most recently
from
0a86d48 to
6568e79
Compare
|
Yes please! Is there a PR?
… On 16 May 2022, at 14:00, Guillaume Fraux ***@***.***> wrote:
The documentation build error is the same one I saw in #129 <#129> and fixed in c10df02 <c10df02>. Let's maybe merge #129 <#129> first, and then rebase this branch?
—
Reply to this email directly, view it on GitHub <#123 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALKVP3UQCMBPHHHMEKHXE3TVKI2FVANCNFSM5JPGHV6Q>.
You are receiving this because you authored the thread.
|
rosecers
force-pushed
the
fix_csd1000r
branch
2 times, most recently
from
f395b1a to
8441ac0
Compare
rosecers
force-pushed
the
fix_csd1000r
branch
2 times, most recently
from
a42d2a3 to
ae695e9
Compare
Luthaf
reviewed
May 16, 2022
…new syntax, and contain up-to-date docs Replacing csd in sample selection with california because the larger dataset means a few redundant samples, which is not good for stable testing Using literal include Update skcosmo/datasets/descr/csd-1000r.rst Co-authored-by: Guillaume Fraux <luthaf@luthaf.fr>
Luthaf
approved these changes
May 20, 2022
victorprincipe
pushed a commit
that referenced
this pull request
May 23, 2022
#123) * Removed boston dataset from tests and examples` * Updating csd-1000r to contain a sufficient number of sample, use the new syntax, and contain up-to-date docs Replacing csd in sample selection with california because the larger dataset means a few redundant samples, which is not good for stable testing Using literal include Update skcosmo/datasets/descr/csd-1000r.rst Co-authored-by: Guillaume Fraux <luthaf@luthaf.fr> Co-authored-by: Guillaume Fraux <luthaf@luthaf.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…new syntax, and contain up-to-date docs