Replaced lambda statement to allow saving of GreedySelector using pic… #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…kle. Progress bar (tqdm) is now always retrieved, but disabled if progress_bar is set to False.
rosecers
force-pushed
the
bug_fix/pickle_GreedySelector
branch
from
b78ea3d to
2576c42
Compare
…kle. Progress bar (tqdm) is now always retrieved, but disabled if progress_bar is set to False. Reformatted using black
rosecers
force-pushed
the
bug_fix/pickle_GreedySelector
branch
from
2576c42 to
aa317f6
Compare
…rom _selection.py, replacing the lambda statement that is causing issue #99.
Luthaf
reviewed
Jun 8, 2022
| deps = | ||
| coverage[toml] | ||
| parameterized | ||
| deps = -rtests/requirements.txt |
There was a problem hiding this comment.
Why would we need a separate file here? You could add tqdm directly in pyproject.toml
There was a problem hiding this comment.
I added this to be consistent with examples and to make it easier to find the testing dependencies.
Luthaf
approved these changes
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed issue #99 - replaced lambda statement to allow saving of GreedySelector using pickle.
Progress bar is retrieved with progress_bar() if self.progress_bar is True. If False, the identity function no_progress_bar() is passed, allowing the line 223
for n in self.report_progress(range(n_iterations))to remain unchanged.