-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change doclayout pydata #204
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is super and useful. We can do some improvements to the layout.
docs/requirements.txt
Outdated
@@ -2,3 +2,4 @@ sphinx | |||
sphinx_rtd_theme |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this if we switch to a new style.
docs/src/index.rst
Outdated
.. raw:: html | ||
|
||
<div class="container"> | ||
<div class="row"> | ||
<div class="col-lg-6 col-md-6 col-sm-6 col-xs-12 d-flex"> | ||
<div class="card text-center intro-card shadow"> | ||
<div class="card-body flex-fill"> | ||
<h5 class="card-title"> | ||
|
||
|
||
.. only:: html | ||
|
||
.. image:: /examples/selection/images/thumb/sphx_glr_FeatureSelection-WHODataset_thumb.png | ||
:alt: | ||
|
||
:ref:`getting_started-selection` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is super nice these cards!
Can you maybe set the background to transparent. Dark mode user here. 😝
Also, can we maybe have the three cards in one line for widescreens and responsivly stacked. Seems like you are using bootstrap. I think there is an option. We can look together.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreement on the transparency, also a dark mode user
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
ac930ac
to
8048a3f
Compare
* toctree is now hidden because the added content is automatically added to the center navbar in the top
* the edit buttion redirects to the corresponding document on github
5f72105
to
9ef24bd
Compare
143b918
to
d43053d
Compare
d43053d
to
de1f277
Compare
thanks for the frontend work, looks better. Would squash your commit with my last commit 9ef24bd and then can be merged by rebase from my side. |
* the sphinx gallery examples are used to visualize the different features of the library that link to the getting started page --------- Co-authored-by: Philip Loche <ploche@physik.fu-berlin.de>
de1f277
to
dba744f
Compare
Yes, I am not 100% happy but I can not use another hour on this. 😅 I approve when you rebased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again. I like the new design!
See commit messages for changes and look at documentation preview.
📚 Documentation preview 📚: https://scikit-matter--204.org.readthedocs.build/en/204/