Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change doclayout pydata #204

Merged
merged 4 commits into from
Aug 15, 2023
Merged

Change doclayout pydata #204

merged 4 commits into from
Aug 15, 2023

Conversation

agoscinski
Copy link
Collaborator

@agoscinski agoscinski commented Jul 28, 2023

See commit messages for changes and look at documentation preview.


📚 Documentation preview 📚: https://scikit-matter--204.org.readthedocs.build/en/204/

Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is super and useful. We can do some improvements to the layout.

@@ -2,3 +2,4 @@ sphinx
sphinx_rtd_theme
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this if we switch to a new style.

Comment on lines 9 to 18
.. raw:: html

<div class="container">
<div class="row">
<div class="col-lg-6 col-md-6 col-sm-6 col-xs-12 d-flex">
<div class="card text-center intro-card shadow">
<div class="card-body flex-fill">
<h5 class="card-title">


.. only:: html

.. image:: /examples/selection/images/thumb/sphx_glr_FeatureSelection-WHODataset_thumb.png
:alt:

:ref:`getting_started-selection`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super nice these cards!

Can you maybe set the background to transparent. Dark mode user here. 😝

Also, can we maybe have the three cards in one line for widescreens and responsivly stacked. Seems like you are using bootstrap. I think there is an option. We can look together.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreement on the transparency, also a dark mode user

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

Base automatically changed from fixing-installation to getting-started August 6, 2023 13:50
@agoscinski agoscinski force-pushed the getting-started branch 3 times, most recently from ac930ac to 8048a3f Compare August 15, 2023 06:12
Base automatically changed from getting-started to main August 15, 2023 07:36
* toctree is now hidden because the added content is automatically added
  to the center navbar in the top
* the edit buttion redirects to the corresponding document on github
@PicoCentauri
Copy link
Collaborator

The cards are very nice. I did some minor changes to the layout. I removed the shadows and let the cards stack a bit better on the desktop and phone

Screenshot 2023-08-15 at 11 33 19 Screenshot 2023-08-15 at 11 33 31

@agoscinski
Copy link
Collaborator Author

agoscinski commented Aug 15, 2023

thanks for the frontend work, looks better. Would squash your commit with my last commit 9ef24bd and then can be merged by rebase from my side.

* the sphinx gallery examples are used to visualize the different
  features of the library that link to the getting started page

---------

Co-authored-by: Philip Loche <ploche@physik.fu-berlin.de>
@PicoCentauri
Copy link
Collaborator

Yes, I am not 100% happy but I can not use another hour on this. 😅

I approve when you rebased.

Copy link
Collaborator

@PicoCentauri PicoCentauri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again. I like the new design!

@agoscinski agoscinski merged commit 1e597e9 into main Aug 15, 2023
@agoscinski agoscinski deleted the doclayout-pydata branch August 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants