Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Assert bundle tractograms and data in bundling script #58

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhlegarreta
Copy link
Contributor

Assert bundle tractograms and data in bundling script according to the set of expected bundles:

  • Make sure that all config files involved contain all the bundles existing in the anatomy file.
  • Filter any other tractogram file in the atlas folder.

Add the necessary helper methods and definitions.

Add the corresponding tests.

Fixes #57.

Assert bundle tractograms and data in bundling script according to the
set of expected bundles:
- Make sure that all config files involved contain all the bundles
  existing in the anatomy file.
- Filter any other tractogram file in the atlas folder.

Add the necessary helper methods and definitions.

Add the corresponding tests.
@github-actions github-actions bot added area:io Items affecting the io module type:testing Guarantee that the code is working/ensure that the results match the expected ones type:enhancement New feature or request labels May 6, 2023
@jhlegarreta
Copy link
Contributor Author

inform the user about the presence of other files in the atlas folder that do not correspond to the bundle names in the anatomy config files

I chose not to inform the user about it; I think it is enough with filtering the files that are not relevant; by providing a config, it is understood that the user is aware of the target bundles.

@jhlegarreta
Copy link
Contributor Author

jhlegarreta commented May 6, 2023

Package testing failures are unrelated; PR #59 was opened to try to address them, but it looks like the dependency solver is unable to find a solution for pandas. Needs to be investigated, but the current PR is good as it is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:io Items affecting the io module type:enhancement New feature or request type:testing Guarantee that the code is working/ensure that the results match the expected ones
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter target tractograms depending on the provided anatomy file
1 participant