ENH: Transition to Python 3.10 #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
type:infrastructure
github-actions
bot
added
type:enhancement
github-actions
bot
added
type:enhancement
github-actions
bot
added
type:enhancement
github-actions
bot
added
type:enhancement
github-actions
bot
added
type:enhancement
github-actions
bot
added
type:enhancement
github-actions
bot
added
type:enhancement
github-actions
bot
added
type:enhancement
|
OK, all failed attempts maybe due to |
jhlegarreta
force-pushed
the
UpgradeScilpy
branch
from
e7cf718 to
345e6d6
Compare
github-actions
bot
added
the
type:documentation
github-actions
bot
added
type:enhancement
jhlegarreta
force-pushed
the
UpgradeScilpy
branch
from
24971fa to
b1f3ee4
Compare
github-actions
bot
added
type:enhancement
jhlegarreta
force-pushed
the
UpgradeScilpy
branch
from
b1f3ee4 to
b0d26f6
Compare
github-actions
bot
added
type:enhancement
jhlegarreta
force-pushed
the
UpgradeScilpy
branch
from
b0d26f6 to
baec3de
Compare
github-actions
bot
added
type:enhancement
jhlegarreta
force-pushed
the
UpgradeScilpy
branch
from
baec3de to
9d0bcae
Compare
github-actions
bot
added
type:enhancement
jhlegarreta
force-pushed
the
UpgradeScilpy
branch
from
9d0bcae to
df1929d
Compare
github-actions
bot
added
type:enhancement
jhlegarreta
force-pushed
the
UpgradeScilpy
branch
from
df1929d to
1a8af35
Compare
github-actions
bot
added
type:enhancement
Transition to Python 3.10. Bump `scilpy` to eb5d3fb and upgrade dependencies accordingly. Remove the dependencies force-upgrade in the package testing workflow, as the versions required by `scilpy` are now modern enough to avoid the primary issues they intended to fix. Specifically, fix the BLAS option warning in `numpy` triggered by `python-spams` when using an earlier version of `numpy`. Fixes: ``` AttributeError: module 'numpy.__config__' has no attribute 'blas_opt_info' ERROR: Failed building wheel for python-spams ``` reported in: https://github.com/scil-vital/tractolearn/actions/runs/4901866945/jobs/8753373506#step:5:945 Also, avoid using the `scilpy`-patched `dipy` version installation issues reporting Cython is not being found by installing a more recent version of `scilpy` using the commit hash. Fixes ``` RuntimeError: Need cython>=0.29.24 to build extensions but cannot import "Cython" ``` repored in https://github.com/scil-vital/tractolearn/actions/runs/5384681010/jobs/9772886628#step:5:996
jhlegarreta
force-pushed
the
UpgradeScilpy
branch
from
1a8af35 to
4740bd8
Compare
github-actions
bot
added
type:enhancement
jhlegarreta
changed the title
scilpy to version 1.5.0 and upgrade dependencies
|
Going ahead and merging @felixdumais. |
|
Using a recent commit hash for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transition to Python 3.10.
Bump
scilpyto eb5d3fb and upgrade dependencies accordingly.Remove the dependencies force-upgrade in the package testing workflow,
as the versions required by
scilpyare now modern enough to avoid theprimary issues they intended to fix.
Specifically, fix the BLAS option warning in
numpytriggered bypython-spamswhen using an earlier version ofnumpy. Fixes:reported in:
https://github.com/scil-vital/tractolearn/actions/runs/4901866945/jobs/8753373506#step:5:945
Also, avoid using the
scilpy-patcheddipyversion installationissues reporting Cython is not being found by installing a more recent
version of
scilpyusing the commit hash. Fixesrepored in
https://github.com/scil-vital/tractolearn/actions/runs/5384681010/jobs/9772886628#step:5:996