Skip to content

Commit

Permalink
topology: replace 'foo' in the tests with a hostname that fails (#3786)
Browse files Browse the repository at this point in the history
`foo` is used in a test to represent a name that will fail to resolve. It exists sometimes (e.g. in the ETH).

Change it to some more weird name so it fails resolving it.
  • Loading branch information
juagargi authored Jun 16, 2020
1 parent e243193 commit 548a7ef
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions go/lib/topology/topology_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -377,7 +377,7 @@ func TestExternalDataPlanePort(t *testing.T) {
Name: "Bad invalid public",
Raw: &jsontopo.BRInterface{
Underlay: jsontopo.Underlay{
Public: "foo:42",
Public: "thishostdoesnotexist:42",
},
},
ExpectedError: assert.Error,
Expand Down Expand Up @@ -414,7 +414,7 @@ func TestExternalDataPlanePort(t *testing.T) {
Raw: &jsontopo.BRInterface{
Underlay: jsontopo.Underlay{
Public: "127.0.0.1:42",
Bind: "foo",
Bind: "thishostdoesnotexist",
},
},
ExpectedError: assert.Error,
Expand Down Expand Up @@ -465,7 +465,7 @@ func TestExternalDataPlanePort(t *testing.T) {
Raw: &jsontopo.BRInterface{
Underlay: jsontopo.Underlay{
Public: "[::1]:42",
Bind: "foo",
Bind: "thishostdoesnotexist",
},
},
ExpectedError: assert.Error,
Expand Down Expand Up @@ -495,7 +495,7 @@ func TestRawAddrMap_ToTopoAddr(t *testing.T) {
{
name: "IPvX invalid address",
assertError: assert.Error,
raw: "foo:42",
raw: "thishostdoesnotexist:42",
},
{
name: "IPv4 invalid port",
Expand Down

0 comments on commit 548a7ef

Please sign in to comment.