Skip to content

Commit

Permalink
nogo: enable checks again (#3834)
Browse files Browse the repository at this point in the history
Enable checks that were disabled due to misconfiguration
  • Loading branch information
oncilla authored Jul 15, 2020
1 parent c65501c commit 9496485
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 7 deletions.
8 changes: 7 additions & 1 deletion go/lib/sigjson/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,16 @@ go_library(
],
)

filegroup(
name = "testdata",
srcs = glob(["testdata/**"]),
visibility = ["//visibility:public"],
)

go_test(
name = "go_default_test",
srcs = ["config_test.go"],
data = glob(["testdata/**"]),
data = [":testdata"],
embed = [":go_default_library"],
deps = [
"//go/lib/addr:go_default_library",
Expand Down
1 change: 0 additions & 1 deletion go/lib/sigjson/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@

// Package sigjson is responsible for parsing the SIG json config file into a
// set of simple intermediate data-structures.

package sigjson

import (
Expand Down
10 changes: 8 additions & 2 deletions go/tools/udpproxy/udpproxy.go
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,14 @@ func Proxy(localX, remoteX, localY, remoteY string) error {
),
)

go redirect(xConn, yConn, ryAddr)
go redirect(yConn, xConn, rxAddr)
go func() {
defer log.HandlePanic()
redirect(xConn, yConn, ryAddr)
}()
go func() {
defer log.HandlePanic()
redirect(yConn, xConn, rxAddr)
}()
select {}
}

Expand Down
6 changes: 3 additions & 3 deletions nogo.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
"nilness": {
"only_files": {
"//go/": "https://github.com/bazelbuild/rules_go/issues/2172"
"/go/": "https://github.com/bazelbuild/rules_go/issues/2172"
},
"exclude_files": {
"gazelle/cmd/gazelle/diff.go": "",
Expand All @@ -40,7 +40,7 @@
},
"unsafeptr": {
"only_files": {
"//go/": "https://github.com/bazelbuild/rules_go/issues/2172"
"/go/": "https://github.com/bazelbuild/rules_go/issues/2172"
},
"exclude_files": {
"/com_github_mattn_go_sqlite3/": "",
Expand All @@ -64,7 +64,7 @@
},
"gocall": {
"only_files": {
"//go/": "https://github.com/bazelbuild/rules_go/issues/2172"
"/go/": "https://github.com/bazelbuild/rules_go/issues/2172"
},
"exclude_files": {
"(vendor|external)/*": "Only applies to internal files",
Expand Down

0 comments on commit 9496485

Please sign in to comment.