Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disp: improve metrics #3101

Closed
kormat opened this issue Sep 5, 2019 · 0 comments · Fixed by #3258
Closed

Disp: improve metrics #3101

kormat opened this issue Sep 5, 2019 · 0 comments · Fixed by #3258
Assignees
@scrye
Labels
c/dispatcher SCION dispatcher c/observability Metrics, logging, tracing feature New feature or request

Comments

@kormat
Copy link
Contributor

kormat commented Sep 5, 2019

  • Less verbose metrics/labels, please: 
    dispatcher_open_application_connections{elem="dispatcher",open_connection_type="no_svc"} 2
    is a lot more characters than required. Suggestion: 
    disp_app_sockets_open{elem="dispatcher", type="no_svc"} 2
  • It would be good to name the ringbuf, so that it's purpose is visible in metrics.
  • Metrics on app connections opening/closing
  • Metrics on app connection errors
  • Metrics on packet sending errors
  • Metrics on packet parsing errors
  • SCMP metrics:
    • pings/traceroutes/recordpath metrics
    • errors by type
  • application-not-found errors
  • traffic by svc
  • receive socket buffer overflows (from go/lib/overlay/conn).
@kormat kormat added c/dispatcher SCION dispatcher c/observability Metrics, logging, tracing labels Sep 5, 2019
@scrye scrye self-assigned this Sep 16, 2019
@scrye scrye added the feature New feature or request label Oct 9, 2019
@scrye scrye mentioned this issue Oct 17, 2019
Merged
scrye added a commit that referenced this issue Oct 21, 2019
@scrye
Add metrics to the Go dispatcher (#3258)
0ea3b18 
Also fixes a panic bug in go/lib/scmp.

Adds the following metrics:
```
# HELP disp_app_conn_reg_errors_total Application socket registration errors
# TYPE disp_app_conn_reg_errors_total counter
disp_app_conn_reg_errors_total 0
# HELP disp_app_not_found_errors_total Number of packets for which the destination application was not found.
# TYPE disp_app_not_found_errors_total counter
disp_app_not_found_errors_total 43
# HELP disp_app_read_bytes_total Total bytes read from applications.
# TYPE disp_app_read_bytes_total counter
disp_app_read_bytes_total 1.0394091e+07
# HELP disp_app_read_errors_total Total errors when reading packets from applications
# TYPE disp_app_read_errors_total counter
disp_app_read_errors_total 0
# HELP disp_app_read_pkts_total Total packets read from applications
# TYPE disp_app_read_pkts_total counter
disp_app_read_pkts_total 36161
# HELP disp_app_sockets_open Number of sockets currently opened by applications.
# TYPE disp_app_sockets_open gauge
disp_app_sockets_open{type="BS A (0x0000)"} 16
disp_app_sockets_open{type="CS A (0x0002)"} 16
disp_app_sockets_open{type="PS A (0x0001)"} 16
disp_app_sockets_open{type="UNKNOWN M (0xffff)"} 216
# HELP disp_app_write_bytes_total Total bytes sent to applications.
# TYPE disp_app_write_bytes_total counter
disp_app_write_bytes_total 1.0390873e+07
# HELP disp_app_write_errors_total Send packet to applications errors.
# TYPE disp_app_write_errors_total counter
disp_app_write_errors_total 0
# HELP disp_app_write_pkts_total Total packets sent to applications.
# TYPE disp_app_write_pkts_total counter
disp_app_write_pkts_total 36118
# HELP disp_app_write_svc_pkts_total Total SVC packets delivered to applications
# TYPE disp_app_write_svc_pkts_total counter
disp_app_write_svc_pkts_total{type="BS A (0x0000)"} 458
disp_app_write_svc_pkts_total{type="BS M (0x8000)"} 1276
disp_app_write_svc_pkts_total{type="CS A (0x0002)"} 37
disp_app_write_svc_pkts_total{type="PS A (0x0001)"} 737
# HELP disp_net_read_bytes_total Total bytes received from the network irrespective of packet outcome.
# TYPE disp_net_read_bytes_total counter
disp_net_read_bytes_total 1.0394091e+07
# HELP disp_net_read_overflow_pkts_total Total ingress packets that were dropped on the OS socket
# TYPE disp_net_read_overflow_pkts_total counter
disp_net_read_overflow_pkts_total 0
# HELP disp_net_read_parse_errors_total Total network packet parse error
# TYPE disp_net_read_parse_errors_total counter
disp_net_read_parse_errors_total 0
# HELP disp_net_read_pkts_total Total packets received from the network.
# TYPE disp_net_read_pkts_total counter
disp_net_read_pkts_total{incoming_packet_result="ok"} 36161
# HELP disp_net_write_bytes_total Total bytes sent on the network.
# TYPE disp_net_write_bytes_total counter
disp_net_write_bytes_total 1.0394091e+07
# HELP disp_net_write_errors_total Network packet send errors
# TYPE disp_net_write_errors_total counter
disp_net_write_errors_total 0
# HELP disp_net_write_pkts_total Total packets sent on the network.
# TYPE disp_net_write_pkts_total counter
disp_net_write_pkts_total 36161
```

Fixes #3101.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scrye scrye

Labels
c/dispatcher SCION dispatcher c/observability Metrics, logging, tracing feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metrics to the Go dispatcher
2 participants
@scrye @kormat