Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib/snet: expose metrics #3107

Closed
kormat opened this issue Sep 5, 2019 · 1 comment · Fixed by #3257
Closed

lib/snet: expose metrics #3107

kormat opened this issue Sep 5, 2019 · 1 comment · Fixed by #3257
Assignees
@scrye
Labels
c/observability Metrics, logging, tracing feature New feature or request

Comments

@kormat
Copy link
Contributor

kormat commented Sep 5, 2019 •
edited
Loading

  • Packets received/sent
  • Bytes received/sent
  • DialSCION/ListenSCION/Conn.Close() counters.
  • Packet parsing errors
  • SCMP errors
  • Dispatcher errors/reconnects

Ideally this would be done such that an app doesn't have to initialize the metrics if it doesn't care about any of that.
@kormat kormat added the c/observability Metrics, logging, tracing label Sep 5, 2019
This was referenced Sep 6, 2019
Closed
Closed
@scrye scrye changed the title snet: export metrics snet: expose metrics Sep 16, 2019
@scrye scrye changed the title snet: expose metrics lib/snet: expose metrics Sep 16, 2019
@scrye
Copy link
Contributor

scrye commented Sep 16, 2019

Renamed similarly to other existing issues.

@scrye scrye self-assigned this Sep 16, 2019
@scrye scrye added feature New feature or request SNET labels Oct 9, 2019
@scrye scrye mentioned this issue Oct 16, 2019
Merged
scrye added a commit that referenced this issue Oct 21, 2019
@scrye
Add metrics to snet (#3257)
acc86dd 
Metrics example:
```
# HELP lib_snet_closes_total Total number of Close calls.
# TYPE lib_snet_closes_total counter
lib_snet_closes_total 0
# HELP lib_snet_dials_total Total number of Dial calls.
# TYPE lib_snet_dials_total counter
lib_snet_dials_total 0
# HELP lib_snet_dispatcher_error_total Total number of dispatcher errors
# TYPE lib_snet_dispatcher_error_total counter
lib_snet_dispatcher_error_total 0
# HELP lib_snet_listens_total Total number of Listen calls.
# TYPE lib_snet_listens_total counter
lib_snet_listens_total 2
# HELP lib_snet_parse_error_total Total number of parse errors
# TYPE lib_snet_parse_error_total counter
lib_snet_parse_error_total 0
# HELP lib_snet_read_total_bytes Total number of bytes read
# TYPE lib_snet_read_total_bytes counter
lib_snet_read_total_bytes 1.163921e+06
# HELP lib_snet_read_total_pkts Total number of packetes read
# TYPE lib_snet_read_total_pkts counter
lib_snet_read_total_pkts 3105
# HELP lib_snet_scmp_error_total Total number of SCMP errors
# TYPE lib_snet_scmp_error_total counter
lib_snet_scmp_error_total 0
# HELP lib_snet_write_total_bytes Total number of bytes written
# TYPE lib_snet_write_total_bytes counter
lib_snet_write_total_bytes 579712
# HELP lib_snet_write_total_pkts Total number of packets written
# TYPE lib_snet_write_total_pkts counter
lib_snet_write_total_pkts 3037
```

Fixes #3107
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scrye scrye

Labels
c/observability Metrics, logging, tracing feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add metrics to snet
2 participants
@scrye @kormat