Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

segfetcher: already requested segment types should be considered cached. #3234

Closed
lukedirtwalker opened this issue Oct 9, 2019 · 0 comments · Fixed by #3235
Closed

segfetcher: already requested segment types should be considered cached. #3234

lukedirtwalker opened this issue Oct 9, 2019 · 0 comments · Fixed by #3235
Assignees
@lukedirtwalker
Labels
bug Something isn't working

Comments

@lukedirtwalker
Copy link
Collaborator

In the segfetcher loop we first resolve segments and check the NextQuery table to see what is cached. Then we request missing data. If multiple core request are done and revocations are involved it can happen that the NextQuery entry for an already requested core segment is deleted. So in the next resolve phase the request is again identified as to be fetched.

To prevent this we should make sure that for each segment type we only fetch once per path request.
@lukedirtwalker lukedirtwalker added bug Something isn't working SCIOND labels Oct 9, 2019
@lukedirtwalker lukedirtwalker self-assigned this Oct 9, 2019
@lukedirtwalker lukedirtwalker mentioned this issue Oct 9, 2019
Merged
lukedirtwalker added a commit that referenced this issue Oct 11, 2019
@lukedirtwalker
segfetcher: Keep next query entries when receiving revocations (#3235)
a46d9cd 
Instead of deleting next query entries when receiving revocation, be smarter when querying:
That means if a query returns no result after being filtered with revocations, try to refetch, otherwise return cached result to clients.

Fixes #3234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedirtwalker lukedirtwalker

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

segfetcher: Keep next query entries when receiving revocations lukedirtwalker/scion
1 participant
@lukedirtwalker