Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert scmp_error_pyintegration test to border acceptance test #3422

Closed
lukedirtwalker opened this issue Nov 22, 2019 · 0 comments · Fixed by #3447
Closed

Convert scmp_error_pyintegration test to border acceptance test #3422

lukedirtwalker opened this issue Nov 22, 2019 · 0 comments · Fixed by #3447
Assignees
@lukedirtwalker
Labels
feature New feature or request i/devops Everything related to CI/Bazel/building

Comments

@lukedirtwalker
Copy link
Collaborator

It doesn't really make sense to run a full topology for testing a single border router.
By converting this to an acceptance test, we have a good blackbox test of a border router, which could also be used to test different implementations.

Additionally this allows us to get rid of more python code.
@lukedirtwalker lukedirtwalker added the feature New feature or request label Nov 22, 2019
@scrye scrye added the i/devops Everything related to CI/Bazel/building label Nov 25, 2019
@lukedirtwalker lukedirtwalker self-assigned this Dec 2, 2019
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Dec 3, 2019
@lukedirtwalker
BR: Test SCMP behaviour in border acceptance
a24c0ad 
Instead of the old python test that spins up a whole topology only test against a BR.
Also extend the acceptance framework with the needed bits.
Also make BR return an SCMP error if it receives traffic for an unknown interface.

Fixes scionproto#3422
@lukedirtwalker lukedirtwalker mentioned this issue Dec 3, 2019
Merged
lukedirtwalker added a commit to lukedirtwalker/scion that referenced this issue Dec 4, 2019
@lukedirtwalker
BR: Test SCMP behaviour in border acceptance
26b7dee 
Instead of the old python test that spins up a whole topology only test against a BR.
Also extend the acceptance framework with the needed bits.
Also make BR return an SCMP error if it receives traffic for an unknown interface.

Fixes scionproto#3422
lukedirtwalker added a commit that referenced this issue Dec 4, 2019
@lukedirtwalker
BR: Test SCMP behaviour in border acceptance (#3447)
6be2063 
Instead of the old python test that spins up a whole topology only test against a BR.
Also extend the acceptance framework with the needed bits.
Also make BR return an SCMP error if it receives traffic for an unknown interface.

Fixes #3422
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lukedirtwalker lukedirtwalker

Labels
feature New feature or request i/devops Everything related to CI/Bazel/building
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

BR: Test SCMP behaviour in border acceptance lukedirtwalker/scion
2 participants
@lukedirtwalker @scrye