Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pathpol: Change policy in options #2349

Merged
merged 3 commits into from
Aug 29, 2019
Merged

Conversation

worxli
Copy link
Contributor

@worxli worxli commented Jan 16, 2019

Change policy in pathpol.Options to ExtPolicy. This is required so an option can not only have anonymous policies, but also extend others.


This change is Reviewable

@worxli worxli requested a review from sustrik January 16, 2019 09:41
@lukedirtwalker lukedirtwalker self-requested a review August 29, 2019 07:16
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik and @worxli)


go/lib/pathpol/policy_test.go, line 855 at r2 (raw file):

	})
	jsonPol, err := json.Marshal(policy)
	if assert.NoError(t, err) {

we usually just use require.NoError(t, err) so the if isn't needed.

Copy link
Contributor Author

@worxli worxli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @lukedirtwalker and @sustrik)


go/lib/pathpol/policy_test.go, line 855 at r2 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

we usually just use require.NoError(t, err) so the if isn't needed.

Done.

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sustrik)

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sustrik)

@worxli worxli merged commit 7b76f7a into scionproto:master Aug 29, 2019
@worxli worxli deleted the pathpol-options branch August 29, 2019 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants