-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pathpol: Change policy in options #2349
Conversation
1020293
to
fee30f8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 2 of 2 files at r2.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @sustrik and @worxli)
go/lib/pathpol/policy_test.go, line 855 at r2 (raw file):
}) jsonPol, err := json.Marshal(policy) if assert.NoError(t, err) {
we usually just use require.NoError(t, err)
so the if isn't needed.
b96d52e
to
3bce2f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @lukedirtwalker and @sustrik)
go/lib/pathpol/policy_test.go, line 855 at r2 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
we usually just use
require.NoError(t, err)
so the if isn't needed.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sustrik)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @sustrik)
Change policy in pathpol.Options to ExtPolicy. This is required so an option can not only have anonymous policies, but also extend others.
This change is