Move segutil from PS to revcache #3041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The functionality is added functionality to the revocation cache. It should therefore be in the revcache package so that it can be used by other services as well.
oncilla
requested changes
Aug 26, 2019
There was a problem hiding this comment.
Reviewed 14 of 14 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
go/lib/revcache/util_test.go, line 1 at r1 (raw file):
// Copyright 2018 Anapaya Systems
time travel or legit?
lukedirtwalker
commented
Aug 26, 2019
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
go/lib/revcache/util_test.go, line 1 at r1 (raw file):
Previously, Oncilla wrote…
time travel or legit?
Hm well, git thinks it's renamed from the revcache_test.go But the code from segutil_test.go had copyright 2018, so I took the older one.
oncilla
approved these changes
Aug 26, 2019
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality in segutil is added functionality to the revocation cache.
It should therefore be in the revcache package so that it can be used by other services as well.
This change is