Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

segfetcher: Add functionality to delete NextQuery entries #3046

Merged

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Aug 26, 2019

This makes it possible to easily refetch segments for revoked links.
Also for sciond we need to delete next query entries for the refresh flag.

Contributes #2454


This change is Reviewable

@lukedirtwalker lukedirtwalker requested a review from oncilla August 26, 2019 13:44
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker and @oncilla)


go/lib/infra/modules/segfetcher/revocation.go, line 63 at r1 (raw file):

		switch r.Type {
		case proto.PathSegType_up:
			req = Request{Src: r.Seg.LastIA(), Dst: addr.IA{I: r.Seg.FirstIA().I}}

Does this not potentially delete to many entries?

Copy link
Collaborator Author

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @oncilla)


go/lib/infra/modules/segfetcher/revocation.go, line 63 at r1 (raw file):

Previously, Oncilla wrote…

Does this not potentially delete to many entries?

How do you mean? We always store LocalIA -> LocalISD-0 for NextQuery entries for up segments. Fetching up segments at the local PS shouldn't be too much of a problem since it is always local.

Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker force-pushed the pubSegfetcherRevocations branch from e5d64c8 to 7d09ed0 Compare August 27, 2019 07:18
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

This makes it possible to easily refetch segments for revoked links.
Also for sciond we need to delete next query entries  for the refresh flag.
@lukedirtwalker lukedirtwalker force-pushed the pubSegfetcherRevocations branch from 7d09ed0 to 8a65c6b Compare August 27, 2019 08:28
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@lukedirtwalker lukedirtwalker merged commit a178cff into scionproto:master Aug 27, 2019
@lukedirtwalker lukedirtwalker deleted the pubSegfetcherRevocations branch August 27, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants