Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

db-test: Create new context after reopening DB #3062

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Aug 29, 2019

Currently, we see DB unit test failures due to context expiration.
This change adds a new context in the tests for pathdb and beacondb
sqlite to make sure long database loads to not trigger an expired
context.


This change is Reviewable

Currently, we see DB unit test failures due to context expiration.
This change adds a new context in the tests for pathdb and beacondb
sqlite to make sure long database loads to not trigger an expired
context.
@oncilla oncilla marked this pull request as ready for review August 29, 2019 11:34
@oncilla oncilla requested a review from lukedirtwalker August 29, 2019 11:34
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit 5b78a1a into scionproto:master Aug 29, 2019
@oncilla oncilla deleted the pub-db-timeout branch August 29, 2019 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants