Add method to filter segments with a path policy #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
force-pushed
the
pubSegPolicyFilter
branch
from
b3732d9 to
0f4a094
Compare
oncilla
approved these changes
Sep 2, 2019
There was a problem hiding this comment.
Reviewed 7 of 7 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
lukedirtwalker
force-pushed
the
pubSegPolicyFilter
branch
from
0f4a094 to
2a6e0ae
Compare
oncilla
approved these changes
Sep 3, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status:
This method pre-filters a list of segments with a given path policy. Note that filtering with sequences is not easily possible since we do not know where a segment would fit into the sequence (up, core, down). A possibility to add sequence filtering for segments would be to split the sequence into up, core, and down parts. Note that filtering with ACLs should only be done on core segments. Up and down segments contain peering interfaces which might be used in the final path, eventhough the ACL would filter it. Fixes scionproto#2820
lukedirtwalker
force-pushed
the
pubSegPolicyFilter
branch
from
2a6e0ae to
18f9d53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method pre-filters a list of segments with a given path policy.
Note that filtering with sequences is not easily possible since we do not know where a segment would fit into the sequence (up, core, down).
A possibility to add sequence filtering for segments would be to split the sequence into up, core, and down parts.
Note that filtering with ACLs should only be done on core segments.
Up and down segments contain peering interfaces which might be used in the final path, eventhough the ACL would filter it.
Fixes #2820
This change is