Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add seghandler to verify and store segs & revs #3081

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

lukedirtwalker
Copy link
Collaborator

@lukedirtwalker lukedirtwalker commented Sep 2, 2019

Generalizes SegReplyHandler from segfetcher package into seghandler.Handler.
This can be used to for all kind of segment storing and verification also for hidden paths etc.

Fixes #3076


This change is Reviewable

@scrye scrye added feature New feature or request refactor Change that focuses around reducing tech debt labels Sep 2, 2019
Copy link
Contributor

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 19 of 19 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Generalizes `SegReplyHandler` from segfetcher package into `seghandler.Handler`.
This can be used to for all kind of segment storing and verification also for hidden paths etc.

Fixes scionproto#3076
@lukedirtwalker lukedirtwalker merged commit 0740964 into scionproto:master Sep 3, 2019
@lukedirtwalker lukedirtwalker deleted the pubSegProcessor branch September 3, 2019 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request refactor Change that focuses around reducing tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segfetcher: Generalize SegReplyHandler to SegRecsHandler
3 participants