-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generator: Use scion-pki tool #3084
generator: Use scion-pki tool #3084
Conversation
c7e3e7e
to
eab49a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)
python/topology/cert.py, line 30 at r1 (raw file):
class CertGenerator(object):
Looks very clean now 💯
python/topology/config.py, line 270 at r1 (raw file):
for path, value in cust_files[topo_id].items(): write_file(os.path.join(base, elem, path), value) if self.args.cert_server == 'go':
This if would still be more or less relevant
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)
go/tools/scion-pki/internal/certs/cmd.go, line 100 at r1 (raw file):
var genCustomers = &cobra.Command{ Use: "customers", Short: "Collect customer keys",
Nit: genCustomers
vs "Collect customer keys"
Use scion-pki tool in the generator to have one way of generating crypto material. fixes scionproto#1491
e862a58
to
060adb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)
go/tools/scion-pki/internal/certs/cmd.go, line 100 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
Nit:
genCustomers
vs"Collect customer keys"
Done.
python/topology/config.py, line 270 at r1 (raw file):
Previously, lukedirtwalker (Lukas Vogel) wrote…
This if would still be more or less relevant
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2.
Reviewable status: complete! all files reviewed, all discussions resolved
Use scion-pki tool in the generator to have one way of generating
crypto material.
fixes #1491
This change is