Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generator: Use scion-pki tool #3084

Merged
merged 6 commits into from
Sep 4, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Sep 3, 2019

Use scion-pki tool in the generator to have one way of generating
crypto material.

fixes #1491


This change is Reviewable

@oncilla oncilla added the c/tooling SCION network tools label Sep 3, 2019
@oncilla oncilla added this to the Q3S3 milestone Sep 3, 2019
@oncilla oncilla force-pushed the pub-generator-use-scion-pki branch from c7e3e7e to eab49a7 Compare September 3, 2019 16:21
@scrye scrye added the feature New feature or request label Sep 4, 2019
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @oncilla)


python/topology/cert.py, line 30 at r1 (raw file):

class CertGenerator(object):

Looks very clean now 💯


python/topology/config.py, line 270 at r1 (raw file):

                for path, value in cust_files[topo_id].items():
                    write_file(os.path.join(base, elem, path), value)
                    if self.args.cert_server == 'go':

This if would still be more or less relevant

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @oncilla)


go/tools/scion-pki/internal/certs/cmd.go, line 100 at r1 (raw file):

var genCustomers = &cobra.Command{
	Use:   "customers",
	Short: "Collect customer keys",

Nit: genCustomers vs "Collect customer keys"

@oncilla oncilla force-pushed the pub-generator-use-scion-pki branch from e862a58 to 060adb2 Compare September 4, 2019 08:04
Copy link
Contributor Author

@oncilla oncilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 6 files reviewed, 1 unresolved discussion (waiting on @lukedirtwalker)


go/tools/scion-pki/internal/certs/cmd.go, line 100 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

Nit: genCustomers vs "Collect customer keys"

Done.


python/topology/config.py, line 270 at r1 (raw file):

Previously, lukedirtwalker (Lukas Vogel) wrote…

This if would still be more or less relevant

Done.

Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r2.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit 9c88fbf into scionproto:master Sep 4, 2019
@oncilla oncilla deleted the pub-generator-use-scion-pki branch September 4, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/tooling SCION network tools feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the generator use scion-pki
3 participants