Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acceptance: Increase timings in discovery tests #3095

Merged
merged 6 commits into from
Sep 5, 2019

Conversation

oncilla
Copy link
Contributor

@oncilla oncilla commented Sep 5, 2019

This PR increases the timings in the discovery_*_fetches_* tests to account for revocations.


This change is Reviewable

This PR reduces the timings in the `discovery_*_fetches_*` tests.
This should make tests pass faster, and avoid revocations from being
issued.
@oncilla oncilla force-pushed the pub-discovery-acceptance branch from da038cd to 0596088 Compare September 5, 2019 12:12
@oncilla oncilla marked this pull request as ready for review September 5, 2019 13:45
@oncilla oncilla changed the title Acceptance: Reduce timings in discovery tests Acceptance: Increase timings in discovery tests Sep 5, 2019
Copy link
Collaborator

@lukedirtwalker lukedirtwalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 5 of 5 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@oncilla oncilla merged commit 585cfcb into scionproto:master Sep 5, 2019
@oncilla oncilla deleted the pub-discovery-acceptance branch September 3, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants