SPKI: Use RunE in cobra commands #3102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oncilla
force-pushed
the
pub-return-err
branch
from
242359d to
f3b5178
Compare
lukedirtwalker
approved these changes
Sep 6, 2019
There was a problem hiding this comment.
Reviewed 20 of 20 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
This PR is in preparation to the scion-pki testing pipeline. Instead of calling os.Exit() the tests now use cobra to return errors. With this change, unit tests can check the exit codes of the application without building and running the binary by directly invoking the commands.
oncilla
force-pushed
the
pub-return-err
branch
from
f3b5178 to
fd530f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is in preparation to the scion-pki testing pipeline.
Instead of calling os.Exit() the tests now use cobra to return errors.
With this change, unit tests can check the exit codes of the application
without building and running the binary by directly invoking the
commands.
This change is