BS: Make ifstate metric useful #3105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukedirtwalker
approved these changes
Sep 5, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status:complete! all files reviewed, all discussions resolved
Remove the state label from the ifstate metric.
before:
# HELP beacon_srv_ifstate Interface state, 0 means down, 1 up. More details in labels (ifid, state)
# TYPE beacon_srv_ifstate gauge
beacon_srv_ifstate{elem="bs1-ff00_0_110-1",ifid="1",state="Active"} 1
now:
# HELP beacon_srv_ifstate Interface state, 0==inactive/expired/revoked, 1==active
# TYPE beacon_srv_ifstate gauge
beacon_srv_ifstate{elem="bs1-ff00_0_110-1",ifid="1"} 0
fixes scionproto#3103
oncilla
force-pushed
the
pub-metrics-are-fun-and-we-should-feel-happy
branch
from
30892bb to
2b7926a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the state label from the ifstate metric.
before:
now:
fixes #3103
This change is